Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add #[pymodule] mod some_module { ... } #2367

Closed
wants to merge 2 commits into from
Closed

add #[pymodule] mod some_module { ... } #2367

wants to merge 2 commits into from

Conversation

davidhewitt
Copy link
Member

Implements using #[pymodule] directly on modules.

Allows importing other wrapped items with a #[pyo3] use foo;. (Builds on #2366 to do this.)

Allows having a #[pymodule_init] function to run arbitrary code after adding all wrapped items.

Still very unfinished, hopefully it's an interesting proof-of-concept.

See the declarative module in test_module.rs and also pytests/src/lib.rs for examples of how this could be used.

@davidhewitt davidhewitt mentioned this pull request May 10, 2022
Merged
@davidhewitt davidhewitt mentioned this pull request Aug 23, 2022
Merged
@davidhewitt davidhewitt mentioned this pull request Nov 29, 2022
Closed
@davidhewitt davidhewitt mentioned this pull request Mar 30, 2023
Merged
@davidhewitt davidhewitt mentioned this pull request Apr 18, 2023
Open
@davidhewitt davidhewitt mentioned this pull request Jun 2, 2023
Closed
@davidhewitt davidhewitt mentioned this pull request Jun 25, 2023
Closed
@birkenfeld birkenfeld mentioned this pull request Jul 4, 2023
Closed
@davidhewitt
Copy link
Member Author

Superseded by #3294

@davidhewitt davidhewitt closed this Jul 4, 2023
@Tpt Tpt mentioned this pull request Feb 3, 2024
Open
7 tasks
Tpt added a commit to Tpt/pyo3 that referenced this pull request Feb 9, 2024
@Tpt @davidhewitt @birkenfeld
#[pymodule] mod some_module { ... } v3
f3a8f7e 
Based on PyO3#2367 and PyO3#3294

Allows to export classes, native classes, functions and submodules and provide an init function

See test/test_module.rs for an example

Future work:
- update examples, README and guide
- investigate having #[pyclass] and #[pyfunction] directly in the #[pymodule]

Co-authored-by: David Hewitt <mail@davidhewitt.dev>
Co-authored-by: Georg Brandl <georg@python.org>
@Tpt Tpt mentioned this pull request Feb 9, 2024
Merged
Tpt added a commit to Tpt/pyo3 that referenced this pull request Feb 9, 2024
@Tpt @davidhewitt @birkenfeld
#[pymodule] mod some_module { ... } v3
846e128 
Based on PyO3#2367 and PyO3#3294

Allows to export classes, native classes, functions and submodules and provide an init function

See test/test_module.rs for an example

Future work:
- update examples, README and guide
- investigate having #[pyclass] and #[pyfunction] directly in the #[pymodule]

Co-authored-by: David Hewitt <mail@davidhewitt.dev>
Co-authored-by: Georg Brandl <georg@python.org>
Tpt added a commit to Tpt/pyo3 that referenced this pull request Feb 9, 2024
@Tpt @davidhewitt @birkenfeld
#[pymodule] mod some_module { ... } v3
6adfe20 
Based on PyO3#2367 and PyO3#3294

Allows to export classes, native classes, functions and submodules and provide an init function

See test/test_module.rs for an example

Future work:
- update examples, README and guide
- investigate having #[pyclass] and #[pyfunction] directly in the #[pymodule]

Co-authored-by: David Hewitt <mail@davidhewitt.dev>
Co-authored-by: Georg Brandl <georg@python.org>
Tpt added a commit to Tpt/pyo3 that referenced this pull request Feb 9, 2024
@Tpt @davidhewitt @birkenfeld
#[pymodule] mod some_module { ... } v3
bd7ad6b 
Based on PyO3#2367 and PyO3#3294

Allows to export classes, native classes, functions and submodules and provide an init function

See test/test_module.rs for an example

Future work:
- update examples, README and guide
- investigate having #[pyclass] and #[pyfunction] directly in the #[pymodule]

Co-authored-by: David Hewitt <mail@davidhewitt.dev>
Co-authored-by: Georg Brandl <georg@python.org>
Tpt added a commit to Tpt/pyo3 that referenced this pull request Feb 9, 2024
@Tpt @davidhewitt @birkenfeld
#[pymodule] mod some_module { ... } v3
7b36a5a 
Based on PyO3#2367 and PyO3#3294

Allows to export classes, native classes, functions and submodules and provide an init function

See test/test_module.rs for an example

Future work:
- update examples, README and guide
- investigate having #[pyclass] and #[pyfunction] directly in the #[pymodule]

Co-authored-by: David Hewitt <mail@davidhewitt.dev>
Co-authored-by: Georg Brandl <georg@python.org>
Tpt added a commit to Tpt/pyo3 that referenced this pull request Feb 16, 2024
@Tpt @davidhewitt @birkenfeld
#[pymodule] mod some_module { ... } v3
b60eea6 
Based on PyO3#2367 and PyO3#3294

Allows to export classes, native classes, functions and submodules and provide an init function

See test/test_module.rs for an example

Future work:
- update examples, README and guide
- investigate having #[pyclass] and #[pyfunction] directly in the #[pymodule]

Co-authored-by: David Hewitt <mail@davidhewitt.dev>
Co-authored-by: Georg Brandl <georg@python.org>
Tpt added a commit to Tpt/pyo3 that referenced this pull request Feb 19, 2024
@Tpt @davidhewitt @birkenfeld
#[pymodule] mod some_module { ... } v3
5981131 
Based on PyO3#2367 and PyO3#3294

Allows to export classes, native classes, functions and submodules and provide an init function

See test/test_module.rs for an example

Future work:
- update examples, README and guide
- investigate having #[pyclass] and #[pyfunction] directly in the #[pymodule]

Co-authored-by: David Hewitt <mail@davidhewitt.dev>
Co-authored-by: Georg Brandl <georg@python.org>
Tpt added a commit to Tpt/pyo3 that referenced this pull request Feb 21, 2024
@Tpt @davidhewitt @birkenfeld
#[pymodule] mod some_module { ... } v3
50f36fa 
Based on PyO3#2367 and PyO3#3294

Allows to export classes, native classes, functions and submodules and provide an init function

See test/test_module.rs for an example

Future work:
- update examples, README and guide
- investigate having #[pyclass] and #[pyfunction] directly in the #[pymodule]

Co-authored-by: David Hewitt <mail@davidhewitt.dev>
Co-authored-by: Georg Brandl <georg@python.org>
Tpt added a commit to Tpt/pyo3 that referenced this pull request Feb 23, 2024
@Tpt @davidhewitt @birkenfeld
#[pymodule] mod some_module { ... } v3
ceeae21 
Based on PyO3#2367 and PyO3#3294

Allows to export classes, native classes, functions and submodules and provide an init function

See test/test_module.rs for an example

Future work:
- update examples, README and guide
- investigate having #[pyclass] and #[pyfunction] directly in the #[pymodule]

Co-authored-by: David Hewitt <mail@davidhewitt.dev>
Co-authored-by: Georg Brandl <georg@python.org>
github-merge-queue bot pushed a commit that referenced this pull request Feb 24, 2024
@Tpt @davidhewitt @birkenfeld
#[pymodule] mod some_module { ... } v3 (#3815)
e0e3981 
* #[pymodule] mod some_module { ... } v3

Based on #2367 and #3294

Allows to export classes, native classes, functions and submodules and provide an init function

See test/test_module.rs for an example

Future work:
- update examples, README and guide
- investigate having #[pyclass] and #[pyfunction] directly in the #[pymodule]

Co-authored-by: David Hewitt <mail@davidhewitt.dev>
Co-authored-by: Georg Brandl <georg@python.org>

* tests: group exported imports

* Consolidate pymodule macro code to avoid duplicates

* Makes pymodule_init take Bound<'_, PyModule>

* Renames #[pyo3] to #[pymodule_export]

* Gates #[pymodule] mod behind the experimental-declarative-modules feature

* Properly fails on functions inside of declarative modules

---------

Co-authored-by: David Hewitt <mail@davidhewitt.dev>
Co-authored-by: Georg Brandl <georg@python.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@davidhewitt